Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: rpc.go fix error parsing height message #2469

Merged
merged 1 commit into from
Jul 12, 2023
Merged

cmd: rpc.go fix error parsing height message #2469

merged 1 commit into from
Jul 12, 2023

Conversation

tuxcanfly
Copy link
Contributor

@tuxcanfly tuxcanfly commented Jul 12, 2023 •
edited
Loading

Overview

This PR fixes the error message returned by the rpc cli client, when an invalid height is passed to the Get, GetAll commands of the Blob module.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@github-actions github-actions bot added the external Issues created by non node team members label Jul 12, 2023
Wondertan
Wondertan approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tuxcanfly!

@vgonkivs vgonkivs merged commit e41f626 into celestiaorg:main Jul 12, 2023
13 of 17 checks passed
@gitpoap-bot
Copy link

gitpoap-bot bot commented Jul 12, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Celestia Contributor:

GitPOAP: 2023 Celestia Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@vgonkivs vgonkivs vgonkivs approved these changes

@renaynay renaynay renaynay approved these changes

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees
No one assigned
Labels
area:cli external Issues created by non node team members kind:chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuxcanfly @Wondertan @vgonkivs @renaynay